fix(skills): derive bug-triage target repo from the checkout - #5
Merged
Conversation
bug-triage hard-coded aoagents/ReverbCode in 21 places. Run from any
other checkout — this repo is bfoxhound/agent-orchestrator — every gh
call silently targeted the wrong repository: duplicate search returned
nothing from the wrong issue tracker, new issues landed on another repo,
and screenshot raw URLs pointed at asset branches that were pushed
elsewhere.
Resolve the slug once in pre-flight and use it everywhere:
REPO="${AO_TRIAGE_REPO:-$(gh repo view --json nameWithOwner -q .nameWithOwner)}"
Deriving from the checkout keeps triage on the tree being triaged. The
old always-file-upstream behaviour stays available as an explicit
choice via AO_TRIAGE_REPO, which also covers the clone-less Appendix B
flow where gh repo view has nothing to read.
The two body-template URLs (screenshot raw link, issue-ref linkify rule)
move to $REPO as well, since a link template pointing at a fixed repo
has the same misfiling problem as a gh flag. Product-identity prose
(ReverbCode, port 3001, Go paths) is untouched — it matches this tree
and was never the bug.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VjPWzWR3yvT35opqeixiWy
Test Coverage ReportNo TypeScript source files changed in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
skills/bug-triage/SKILL.mdhard-coded--repo aoagents/ReverbCodein 21 places. This checkout isbfoxhound/agent-orchestrator, so anyone running the skill here had everyghcall silently target a different repository: duplicate search queried the wrong issue tracker (and returned nothing), new issues were filed elsewhere, and the screenshot raw-URL template pointed at asset branches pushed to another repo.One issue, one PR, per
AGENTS.md.The fix
Resolve the slug once in pre-flight and use
$REPOeverywhere:REPO="${AO_TRIAGE_REPO:-$(gh repo view --json nameWithOwner -q .nameWithOwner)}"AO_TRIAGE_REPOoverride — preserves the old always-file-upstream intent as an explicit choice (AO_TRIAGE_REPO=aoagents/ReverbCode), and covers the Appendix B clone-less flow wheregh repo viewhas no checkout to read.All 21 sites were converted and reviewed individually rather than by blanket substitution. The ones needing care:
--repoflags adjacent to<<'EOF'heredocs (§4, §5c) sit outside the quoted heredoc, so"$REPO"expands normally.ao spawn --prompt "…"worker instruction (§5f) is a double-quoted string, so$REPOresolves at spawn time and the worker receives the concrete slug.$REPOtoo; a link template aimed at a fixed repo misfiles the same way aghflag does.gh apipaths are now consistently double-quoted ("repos/$REPO/git/trees/main?recursive=1"), which also protects the?from glob-happy shells.Product-identity prose is deliberately untouched: ReverbCode as the product name, port 3001, the Go daemon paths, and the Electron frontend all match this tree (verified against
backend/internal/config/config.go,backend/internal/session_manager/manager.go,frontend/forge.config.ts, andDESIGN.md). Only the repo slug was wrong.Verification
grep -c 'aoagents/ReverbCode'→ exactly 1 remaining literal, the intentionalAO_TRIAGE_REPOexample in the pre-flight bullet.$REPOconstruction passesbash -n.Docs-only change; no code paths affected.
Generated by Claude Code